ObjectSuggestions: Fix exotic columns match #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
requested changes
Jul 22, 2024
library/Notifications/Web/Control/SearchBar/ObjectSuggestions.php
Outdated
Show resolved
Hide resolved
sukhwinder33445
force-pushed
the
fix-exotic-columns-match
branch
from
a0e20aa to
17575ef
Compare
These columns should only be shown if expicitely given by user. Previously, columns with a similar suffix were also found, e.g. the search for `id` also showed `uuid` as search suggestion.
sukhwinder33445
force-pushed
the
fix-exotic-columns-match
branch
from
17575ef to
9d89dec
Compare
nilmerg
approved these changes
Jul 22, 2024
|
Icinga DB Web suffers from the same issue, please open a PR for this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These columns should only be shown if explicitly given by user. Previously, columns with a similar suffix were also found, e.g. the search for
idalso showeduuidas search suggestion.